Android photo picks stop coming unstuck
Pick a photo from Android's system picker and the thumbnail now appears and the upload goes through. The composer copies the file first instead of trusting its metadata.
You tap the picture button on your phone, choose a shot from Android's photo picker, and the thumbnail lands in the strip under the message box instead of a torn-image placeholder. Send it, and the photo goes with your words. Same story in a commit, a reply, a quote, or chat.
Credit goes to a contributor who taught the composer to copy a picked file before doing anything else with it. The bytes stream into memory first, so nothing asks the provider for a size or a timestamp. The preview and the upload both work from the copy. It takes up to three images, stops reading past 10 MB, and accepts JPEG, PNG, and WebP. While a copy is running the send button waits, and throwing the draft away cancels the read.
One catch. It shows only the first bad file. Select three photos and two of them fail, and the strip carries a single error. The second failure stays quiet until you select that photo by itself.
Key files · #494
- resources/
js/ read-picked-images.tslib/ - resources/
js/ draft-image-reads.tslib/ - resources/
js/ use-image-attachments.tshooks/ - resources/
js/ commit-image-picker.tsxcomponents/ - resources/
js/ use-stash.tshooks/ - resources/
js/ commit-composer.tsxcomponents/ - resources/
js/ conversation-thread.tsxcomponents/ chat/ - resources/
js/ commit-thread.tsxcomponents/